Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohomekit to 1.2.10 #76738

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Bump aiohomekit to 1.2.10 #76738

merged 1 commit into from
Aug 14, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 13, 2022

Proposed change

Changes: Jc2k/aiohomekit@1.2.9...1.2.10

Improve error logging when a char or service is missing which may tell us whats going on with #76380 and #76423
Implement bluetooth service caching
Bump bleak-retry-connector>=1.7.1 to fix disconnect race
Bump bleak-retry-connector to 1.7.2 - Fix for devices that go in and out of range frequently
Implement TLV reassembly during pairing
Fix missing padding in SRP - Allows LIFX Beam to pair. may help with #70231

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Changes: Jc2k/aiohomekit@1.2.9...1.2.10

Improve error logging when a char or service is missing
Implement bluetooth service caching
Bump bleak-retry-connector>=1.7.1 to fix disconnect race
Bump bleak-retry-connector to 1.7.2 - Fix for devices that go in and out of range frequently
Implement TLV reassembly during pairing
Fix missing padding in SRP - Allows LIFX Beam to pair

Fixes home-assistant#76399 Fixes home-assistant#73709
@probot-home-assistant
Copy link

Hey there @Jc2k, mind taking a look at this pull request as it has been labeled with an integration (homekit_controller) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@Jc2k Jc2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤馃憤馃憤馃憤

@bdraco bdraco closed this Aug 14, 2022
@bdraco bdraco reopened this Aug 14, 2022
@bdraco bdraco marked this pull request as ready for review August 14, 2022 04:52
@bdraco bdraco added this to the 2022.8.5 milestone Aug 14, 2022
@bdraco bdraco merged commit 5f827f4 into home-assistant:dev Aug 14, 2022
balloob pushed a commit that referenced this pull request Aug 16, 2022
@balloob balloob mentioned this pull request Aug 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.