Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad data with inkbird bbq sensors #76739

Merged
merged 4 commits into from
Aug 15, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 14, 2022

Proposed change

Fixes #76602
Bluetooth-Devices/inkbird-ble@v0.5.2...v0.5.5

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Member Author

bdraco commented Aug 14, 2022

Need to fix the names in the test since the underlying library fixed the overly long names as well

@bdraco bdraco marked this pull request as ready for review August 14, 2022 08:02
@bdraco bdraco closed this Aug 14, 2022
@bdraco bdraco reopened this Aug 14, 2022
@bdraco
Copy link
Member Author

bdraco commented Aug 15, 2022

Thanks

@bdraco bdraco merged commit 9dedba4 into home-assistant:dev Aug 15, 2022
balloob pushed a commit that referenced this pull request Aug 16, 2022
@balloob balloob mentioned this pull request Aug 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INKBIRD IBT-2x - false values
4 participants