Correct referenced entities and devices for event triggers #76818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
integration: automation
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
frenck
approved these changes
Aug 15, 2022
balloob
reviewed
Aug 15, 2022
Comment on lines
+791
to
793
| and isinstance(trigger_conf[CONF_EVENT_DATA][CONF_DEVICE_ID], str) | ||
| ): | ||
| return [trigger_conf[CONF_EVENT_DATA][CONF_DEVICE_ID]] |
There was a problem hiding this comment.
If it's a list, shouldn't we also return the list of device IDs?
There was a problem hiding this comment.
It cannot be a list :)
As in, an event cannot originate from multiple entities at the same time.
balloob
reviewed
Aug 15, 2022
| @@ -1103,6 +1103,24 @@ async def test_extraction_functions(hass): | |||
| "event_type": "state_changed", | |||
| "event_data": {"entity_id": "sensor.trigger_event"}, | |||
| }, | |||
| # entity_id is a list of strings (not supported) | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Correct referenced entities and devices for event triggers.
The filter for the
event_datais not validated, so must check thatevent_data["entity_id"]andevent_data["device_id"]are strings.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: