Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no score to include config flow #2129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gjohansson-ST
Copy link
Member

Proposed change

As with ADR-0010 we need a config flow so it should be a requirement for no score (if applicable)

Type of change

  • Document existing features within Home Assistant
  • Document new or changing features which there is an existing pull request elsewhere
  • Spelling or grammatical corrections, or rewording for improved clarity
  • Changes to the backend of this documentation
  • Removed stale or deprecated documentation

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to relevant existing code or pull request:

@joostlek
Copy link
Member

Hmm, I like the idea to review the quality scale. I do think we will move all non config flow integrations that could use a conversion into a limbo, because apparently they don't align with the bare minimum.

I would like to see some new rules in there that improve code quality like for example:

  • Uses strict typing
  • Efficiently make use of shorthand attributes (i.e., don't store state in self._state if you are directly going to return it in native_value property.
  • Migrate to has_entity_name
  • Make use of translatable entity names
  • Make use of icon translations
  • Be sure to have a predictable state from the code (not the right wording, but my point being, use enum sensors where possible, use proper device classes where possible as these increase the userfriendliness by a lot regarding voice control and automations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants