-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blogpost about changing translation downloads #2136
base: master
Are you sure you want to change the base?
Conversation
With this change, we only download the strings that are verified. | ||
|
||
A verified string is a translated string, and it becomes unverified when the original string changes. | ||
So whenever someone changes something in the original string, the translated string becomes unverified and needs to be reviewed again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"something" is a pleonasm. "reviewed" is another Lokalize concept. Suggestions:
So whenever someone changes something in the original string, the translated string becomes unverified and needs to be reviewed again. | |
So whenever someone changes the default value of a string (i.e. changes a `strings.json` file), all translations of that key becomes unverified and must be edited or marked as verified in Lokalise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So whenever the English string is modified (i.e. changes a strings.json file), all translations which refers to the same translation key becomes unverified and must be edited or marked as verified in Lokalise.
|
||
A verified string is a translated string, and it becomes unverified when the original string changes. | ||
So whenever someone changes something in the original string, the translated string becomes unverified and needs to be reviewed again. | ||
This is very beneficial for the translation keys that make use of translation key placeholders, since they can now never have a mismatch between the original and translated string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is better:
This is very beneficial for the translation keys that make use of translation key placeholders, since they can now never have a mismatch between the original and translated string. | |
This catches both significant changes to strings that may be hidden if the translation is not updated, and also avoids placeholder mismatches. Note that correcting typos in the default strings also will make translations "unverified". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This catches changes to English strings that may be hidden if the translation is not updated, and also avoids placeholder mismatches. Note that correcting typos in the English strings also will make translations "unverified".
@@ -10,7 +10,7 @@ In Home Assistant Core 2024.4.2, we are changing the way translation keys are do | |||
Previously the script would download every translated string. | |||
With this change, we only download the strings that are verified. | |||
|
|||
A verified string is a translated string, and it becomes unverified when the original string changes. | |||
All translations are verified when saved, but a translation becomes unverified if the source string is changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: missing punctuation at end of sentence.
title: "Changing the way translation keys are handled" | ||
--- | ||
|
||
In Home Assistant Core 2024.4.2, we are changing the way translation keys are downloaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found "downloaded" in this context is confusing. From where to where?
In Home Assistant Core 2024.4.2, we are changing the way translation are included into builds from Lokalise.
|
||
In Home Assistant Core 2024.4.2, we are changing the way translation keys are downloaded. | ||
|
||
Previously the script would download every translated string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously the build translation script would download every translated string.
In Home Assistant Core 2024.4.2, we are changing the way translation keys are downloaded. | ||
|
||
Previously the script would download every translated string. | ||
With this change, we only download the strings that are verified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change, we only download the translations that are verified in Lokalise.
Proposed change
Add blogpost about changing translation downloads
Type of change
Additional information