Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change translation rule 6 #2141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

oyvindwe
Copy link

@oyvindwe oyvindwe commented Apr 8, 2024

Proposed change

Change translation rule 6 to not build translation strings based on other keys. This is an anti-pattern, as usages of a string is may not be reviewed. hassfest also disallows this in strings.json.

Type of change

  • Document existing features within Home Assistant
  • Document new or changing features which there is an existing pull request elsewhere
  • Spelling or grammatical corrections, or rewording for improved clarity
  • Changes to the backend of this documentation
  • Removed stale or deprecated documentation

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to relevant existing code or pull request:

Old rule 6 is an anti-pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant