Bump @codemirror packages to version 6.x #14969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steverep
commented
Jan 3, 2023
| @@ -152,10 +153,8 @@ export class HaCodeEditor extends ReactiveElement { | |||
| saveKeyBinding, | |||
| ] as KeyBinding[]), | |||
| this._loadedCodeMirror.langCompartment.of(this._mode), | |||
| this._loadedCodeMirror.theme, | |||
| this._loadedCodeMirror.Prec.fallback( | |||
There was a problem hiding this comment.
It's not clear to me why the precedence for the syntax highlighting was lowered. If this was to account for a bug, there was some fixes for highlighting precedence in the release notes, but I don't know what to check for in HA. I made the assumption it was not needed anymore for now.
This was referenced Jan 3, 2023
This was
linked to
issues
Jan 26, 2023
|
Persistent in 2023.2.0 |
|
@WRoss7 please add your comment to whichever issue you are referring. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This is meant to replace #14783 from dependabot. Nearly all of the packages use dependencies, instead of more accurately using peer dependencies, so these really should be updated as an entire scope when jumping major versions to avoid issues. Apparently they are cautiously making the switch though (codemirror/dev#858). 馃憤馃徎
Most of the changes needed were just to account for package consolidations and a few minor API changes. The only thing I was unsure of is noted in the comment below.
This might close the issues mentioned below, or at least should be the first step to solving them.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: