Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock file maintenance #17341

Merged
merged 1 commit into from Jul 19, 2023
Merged

Lock file maintenance #17341

merged 1 commit into from Jul 19, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 19, 2023

Mend Renovate

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: Branch creation - "on the 19th day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the Dependencies Pull requests that update a dependency file label Jul 19, 2023
@frenck frenck merged commit efc442d into dev Jul 19, 2023
10 checks passed
@frenck frenck deleted the renovate/lock-file-maintenance branch July 19, 2023 11:08
@steverep
Copy link
Member

@frenck FYI for next time, these PRs need to be scanned for creating duplicates of certain packages. For example, this one is duplicating @codemirror/view. It's an unfortunate issue stemming from mostly things out of our control.

@frenck
Copy link
Member

frenck commented Jul 19, 2023

I'm failing to see the issue, sorry 🤷

@@ -1536,6 +1533,17 @@ __metadata:
languageName: node
linkType: hard

"@codemirror/view@npm:^6.0.0, @codemirror/view@npm:^6.6.0":
version: 6.15.3
resolution: "@codemirror/view@npm:6.15.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it's added at 6.15.3 in addition to the pin at 6.14.1 above.

@frenck
Copy link
Member

frenck commented Jul 19, 2023

Thanks, that I spotted... my point was failing to see the issue with it...

@steverep
Copy link
Member

2 copies in the bundle means slower browser loading and potential conflicts when the package has side effects.

@frenck
Copy link
Member

frenck commented Jul 19, 2023

So this means there is a bug in the package manager?

@steverep
Copy link
Member

No, not yarn's fault. Usually the package's dependency tree is to blame. In the case of @codemirror/*, they should be using peer dependencies but do not (codemirror/dev#858).

It'll work itself out when Renovate updates our direct dependency soon. Problem is 6.15 was just released but we have a 3 day wait period set, which lock file maintenance task is not smart enough to respect.

@steverep
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants