Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style fixes #20537

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Style fixes #20537

wants to merge 1 commit into from

Conversation

yosilevy
Copy link
Contributor

Breaking change

Proposed change

Style cleanup - inline

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@silamon
Copy link
Contributor

silamon commented Apr 17, 2024

Some older browsers still don't support the CSS logical properties (like margin-inline-start and margin-inline-end) and fallback to the margin-left and margin-right properties. Removing those will probably take away the margin completely if support is missing, but I'm not entirely sure.

@yosilevy
Copy link
Contributor Author

yosilevy commented May 6, 2024

@silamon @bramkragten some devs on the team started entering only the logical properties so I followed suite. We can decide not to do it yet although I don't think users need this. This is common spread by now.

@bramkragten
Copy link
Member

For the legacy build I want to add a css converter that handles this, let's wait for that

@yosilevy
Copy link
Contributor Author

@bramkragten Should we delete this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants