Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap large integers in double quotes #20669

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

JamesOsborn-SE
Copy link

Breaking change

Proposed change

Change to address issue #13612 numbers larger than Number.MAX_SAFE_INTEGER are mangled, so I added quotes if the number is bigger than that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

I dont think this appies.

Additional information

Checklist

  • The code change is tested and works locally.
  • [X ] There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JamesOsborn-SE

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft April 29, 2024 20:55
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@bramkragten
Copy link
Member

This does not fully fix the issue, and is not a correct fix.

For example this will not be handled correctly:

data:
  number: 111111111111111111111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large numbers are not handled well
2 participants