Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE] add sentences for activating scenes in the area of a satellite device #2136

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

andreasbrett
Copy link
Contributor

@andreasbrett andreasbrett commented Apr 13, 2024

Added awareness of a scene's area based on the area of the triggering satellite device. This might be controversial since this has not yet been added to any other language (at least not EN) and raises the question if scenes should be required to be assigned to an area for them to be triggered via Assist.

Intents for lights require that a light must be in an area. Sentences without an area will then use the satellite's area, sentences with an area will target lights in that area. For scenes this is different, since scenes control not only lights but also other domains. It needs to be discussed if we can require scenes to be assigned to an area for them to be triggered via Assist (just like lights).

For now I circumvented this by requiring the word "hier" to use the satellite's area for targeting. I'm not particularly fond of this though. I'd rather have scenes behave as lights so I can simply ask "aktiviere partymodus" instead of "aktiviere partymodus hier". There might be objections though for those that use scenes area-independent (is that a thing?).

Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andreasbrett
I think this should be discussed first in the ideas or general section of the discussions board

@home-assistant home-assistant bot marked this pull request as draft April 21, 2024 11:19
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants