fix: Use dvh/dvw instead of vh/vw for mobile #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbesingeryeh
approved these changes
Apr 22, 2024
homebound-team-bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
## [2.343.1](v2.343.0...v2.343.1) (2024-04-22) ### Bug Fixes * Use dvh/dvw instead of vh/vw for mobile ([#1016](#1016)) ([cbb86ad](cbb86ad))
|
🎉 This PR is included in version 2.343.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
height: 100dvh(dynamic viewport height) vs100vhas it takes into account the address bar and other "chrome" added around the viewport. This results in a better output for the screen.dvhanddvwhas been supported in iOS, and most browsers since early-mid 2022. More specifically as of iOS/Safari v15.4, Chrome v108, Firefox v101. See MDN docs for a more complete browser support.