fix: Fallback message for virtual table was exceeding table header width #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdow
force-pushed
the
column-size-fallback-fix
branch
from
495cf6d
to
a7650fe
Compare
stephenh
approved these changes
May 10, 2024
src/components/Table/GridTable.tsx
Outdated
| @@ -486,7 +486,7 @@ export function GridTable<R extends Kinded, X extends Only<GridTableXss, X> = an | |||
| <PresentationProvider fieldProps={fieldProps} wrap={style?.presentationSettings?.wrap}> | |||
| {/* If virtualized take some pixels off the width to accommodate when virtuoso's scrollbar is introduced. */} | |||
| {/* Otherwise a horizontal scrollbar will _always_ appear once the vertical scrollbar is needed */} | |||
There was a problem hiding this comment.
Hm, maybe move this comment into the helper method, to explain the - 20px? Could go either way...
homebound-team-bot
pushed a commit
that referenced
this pull request
May 10, 2024
## [2.343.5](v2.343.4...v2.343.5) (2024-05-10) ### Bug Fixes * Fallback message for virtual table was exceeding table header width ([#1020](#1020)) ([60b6f57](60b6f57))
|
🎉 This PR is included in version 2.343.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For virtualized tables we subtract 20px from the total width to account for a vertical scrollbar, which helps prevent horizontal scrollbars. The fallback message was not respecting that adjusted width.