feat: Add new icons #1021
feat: Add new icons #1021
Conversation
khalidwilliams
requested review from
stephenh,
bdow,
ksk5280 and
chr1sjf0x
as code owners
| @@ -63,6 +63,33 @@ describe("BoundCheckboxField", () => { | |||
| click(r.isAvailable); | |||
| // Then the callback should be triggered with the current value | |||
| expect(autoSave).toBeCalledWith(false); | |||
| expect(autoSave).toBeCalledTimes(1); | |||
There was a problem hiding this comment.
Was this a merge conflict or something? Changes seem unrelated?
There was a problem hiding this comment.
Ah yep sorry, this slipped in from some tests I was doing for a different ticket
src/components/Icon.tsx
Outdated
| @@ -813,6 +813,21 @@ export const Icons = { | |||
| fillRule="evenodd" | |||
| /> | |||
| ), | |||
| bxTime: ( | |||
There was a problem hiding this comment.
question: where does this bx prefix come from? Don't see that anywhere else 馃
There was a problem hiding this comment.
I pulled it from the name in the figma file, wasn't sure if it was a new convention there. I can remove it, it's been a while since I added Beam icons
src/components/Icon.tsx
Outdated
| <> | ||
| <path | ||
| d="M12 2C6.486 2 2 6.486 2 12C2 17.514 6.486 22 12 22C17.514 22 22 17.514 22 12C22 6.486 17.514 2 12 2ZM12 20C7.589 20 4 16.411 4 12C4 7.589 7.589 4 12 4C16.411 4 20 7.589 20 12C20 16.411 16.411 20 12 20Z" | ||
| fill="#484848" |
There was a problem hiding this comment.
I believe we usually remove any color attributes and let the icons get colored by the parent CSS
| fill="#484848" | |
src/components/Icon.tsx
Outdated
| <path d="M13 7H11V13H17V11H13V7Z" fill="#484848" /> | ||
| </> | ||
| ), | ||
| bxLockOpenAlt: ( |
There was a problem hiding this comment.
same naming nit and fill nit here - I do see we have an outline convention which is maybe what the alt is pointing to from another icon lib?
nvm I see the updates |
## [2.344.0](v2.343.5...v2.344.0) (2024-05-13) ### Features * Add new icons ([#1021](#1021)) ([40b138d](40b138d))
|
馃帀 This PR is included in version 2.344.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
No description provided.