fix: Allow click events to pass through tooltip wrapped elements #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdow
commented
May 15, 2024
| @@ -36,7 +36,8 @@ export function Tooltip(props: TooltipProps) { | |||
| {...(!state.isOpen && typeof title === "string" ? { title } : {})} | |||
| {...tid} | |||
| // Add display contents to prevent the tooltip wrapping element from short-circuiting inherited styles (i.e. flex item positioning) | |||
| css={Css.display("contents").$} | |||
| // Once the element is `:active`, allow pointer events (i.e. click events) to pass through to the children. | |||
| css={Css.display("contents").addIn(":active", Css.add("pointerEvents", "none").$).$} | |||
There was a problem hiding this comment.
I tried to write a test for this, but couldn't figure out how to get a click event to bubble up in tests. After 5-10minutes of searching and tryings out, I figured a manual test was good enough for now given the state of Beam soon being sunsetted.
chr1sjf0x
approved these changes
May 15, 2024
homebound-team-bot
pushed a commit
that referenced
this pull request
May 15, 2024
## [2.344.2](v2.344.1...v2.344.2) (2024-05-15) ### Bug Fixes * Allow click events to pass through tooltip wrapped elements ([#1023](#1023)) ([b7b8f59](b7b8f59))
|
馃帀 This PR is included in version 2.344.2 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @bsholmes for the solution! 馃帀