Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with socket.io connections failing. #191

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Fix issue with socket.io connections failing. #191

merged 1 commit into from
Feb 24, 2021

Commits on Feb 24, 2021

  1. Fix issue with socket.io connections failing. 

    socket.io sets pfx to null if it is undefined.  This now breaks the https code, which now checks explicitly against pfx === undefined.  Workaround is to set pfx to [].

nodejs/node#36292
    @lmcquade
    lmcquade committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    3dccd2a View commit details
    Browse the repository at this point in the history