Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register the plugin as platform #855

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Register the plugin as platform #855

wants to merge 7 commits into from

Conversation

afharo
Copy link
Member

@afharo afharo commented Dec 12, 2023

Resolves #247

Registering the plugin as platform allows dynamic discovery of the services. Apart from stopping the connection errors we typically see when starting up, it opens the door to future improvements like:

  1. Query the robot before creating the services: a real room discovery feature?
  2. Allow other forms of authentication (Xiaomi Cloud could retrieve the token automatically based on user and password).
  3. Identify the model and the speeds before creating the services.

TODO:

  • Update docs
  • Update config schema
  • Add/Update tests

@afharo afharo self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (ec81661) 50.65% compared to head (abe1cf8) 51.04%.

Files Patch % Lines
src/homebridge_entities/platform_accessory.ts 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
+ Coverage   50.65%   51.04%   +0.38%     
==========================================
  Files          58       62       +4     
  Lines        1516     1573      +57     
  Branches      221      231      +10     
==========================================
+ Hits          768      803      +35     
- Misses        674      696      +22     
  Partials       74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register module in homebridge as platform
1 participant