Improve plugin card hyperlinks #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwp91
reviewed
Dec 8, 2023
| </p> | ||
| <p class="card-text mb-2"> | ||
| <a href="javascript:void(0)" class="card-link pink-text" *ngIf="plugin.verifiedPlugin && plugin.funding" | ||
| (click)="openFundingModal(plugin)"> | ||
| <i class="fas fa-fw fa-heart fa-lg"></i> | ||
| <span *ngIf="!plugin.verifiedPlugin || !plugin.funding"> |
There was a problem hiding this comment.
This won't work here.
The condition on the <a is that *ngIf="plugin.verifiedPlugin && plugin.funding" so having the <span *ngIf="!plugin.verifiedPlugin || !plugin.funding"> inside will not work
In this case the span needs to be kept outside the
There was a problem hiding this comment.
Thanks, I've fixed it and will update shortly
There was a problem hiding this comment.
Fixed with the commit from today, Dec 9, 2023.
|
@jsiegenthaler I didn't notice this PR and added PR myself with many fixes to the plugin card, including this one. |
bwp91
changed the title
Closed
Merged
donavanbecker
added a commit
that referenced
this pull request
Jan 7, 2024
### UI Changes - Add plugin log download button - Improve plugin card hyperlinks (#1918) (@jsiegenthaler) - Download logs option for when a plugin install/update/uninstall fails - revise system information icons (os/node) - accessory title fix (lights + windows) (#1933) (@mkz212) - improve spacing in plugin card - more items in homebridge settings - confirm restart after updating Homebridge instead of automatically restarting - improve child bridge sing/plu in dropdown - move backup/restore + users to hb settings - move hb/ui settings to main menu - create standard settings page + link at top - small changes to plugin card (based on feedback) - fix overflow in markdown changelog - plugin card updates - added credits link in status footer and modal for credits - added more `aria-label` attributes to buttons to improve accessibility - add link to homebridge wiki in logs on plugin action error - allow fan/fanv2 rotation speed to be a different unit than percentage - improve plugin sorting, with actionable plugins at the top - fix footer paddings for mobile and desktop (#1956) (@mkz212) - no need to restart if updating disabled plugin - standardise update modal header ### Translation Changes - updates to pl.json language file (#1929) (@mkz212) - updates to de.json language file (@Staubgeborener) - updates to fr.json language file (@SonnyT72) - updates to de.json language file (#1953) (@Staubgeborener) - updates to pl.json language file (#1954) (@mkz212) ### Other Changes - add `passport` as dependency to BE - revert ngx-monaco-editor dependency update - ui: update to angular v15 - improve github actions - Fix for backup service including npm's cache (#1949) (@sapireli) - updated dependencies - ignore `.venv` in hb backup files - updated Discord Webhooks so notifications are seperated for `release` and `pre-release` - update maximum file upload size to 25mb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
The current Info, Verified and Funding icons are very small as clickable icons on a small iPhone display. This makes them difficult to hit, especially for users with larger fingers.
💡 Proposed solution
The changes expand the hyperlink anchor to the icon and text, so the user can tap the text or icon to access the feature.
The name of the plugin goes to the same hyperlink destination as the Info icon. Colour could be better though
➕ Additional Information
Can someone improve the colour of the now clickable plugin name?