Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.55.0 #1919

Closed
wants to merge 49 commits into from
Closed

4.55.0 #1919

wants to merge 49 commits into from

Conversation

bwp91
Copy link
Contributor

@bwp91 bwp91 commented Dec 8, 2023 •
edited

pre-emptively requesting approval

to be merged on 2024-01-06 (subject to no sudden bugs arising)

semver minor change --> 4.55.0

UI Changes

  • Add plugin log download button
  • Improve plugin card hyperlinks (Improve plugin card hyperlinks #1918) (@jsiegenthaler)
  • Download logs option for when a plugin install/update/uninstall fails
  • revise system information icons (os/node)
  • accessory title fix (lights + windows) (accessory title fix (lights + windows) #1933) (@mkz212)
  • improve spacing in plugin card
  • more items in homebridge settings
  • confirm restart after updating Homebridge instead of automatically restarting
  • improve child bridge sing/plu in dropdown
  • move backup/restore + users to hb settings
  • move hb/ui settings to main menu
  • create standard settings page + link at top
  • small changes to plugin card (based on feedback)
  • fix overflow in markdown changelog
  • plugin card updates
  • added credits link in status footer and modal for credits
  • added more aria-label attributes to buttons to improve accessibility
  • add link to homebridge wiki in logs on plugin action error
  • allow fan/fanv2 rotation speed to be a different unit than percentage
  • improve plugin sorting, with actionable plugins at the top
  • fix footer paddings for mobile and desktop (fix footer paddings for mobile and desktop #1956) (@mkz212)
  • no need to restart if updating disabled plugin
  • standardise update modal header

Translation Changes

Other Changes

  • add passport as dependency to BE
  • revert ngx-monaco-editor dependency update
  • ui: update to angular v15
  • improve github actions
  • Fix for backup service including npm's cache (Fix for backup service including npm's cache, and therefore being too… #1949) (@sapireli)
  • updated dependencies
  • ignore .venv in hb backup files
  • updated Discord Webhooks so notifications are seperated for release and pre-release
  • update maximum file upload size to 25mb

@github-actions github-actions bot added the latest Related to Latest Branch label Dec 8, 2023
@coveralls
Copy link

coveralls commented Dec 9, 2023 •
edited

Pull Request Test Coverage Report for Build 7215006703

  • 22 of 51 (43.14%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 44.249%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/status/status.service.ts 17 27 62.96%
src/modules/plugins/plugins.service.ts 5 24 20.83%
Totals Coverage Status
Change from base Build 7144133247: 0.09%
Covered Lines: 2175
Relevant Lines: 4601
💛 - Coveralls

@bwp91 bwp91 force-pushed the beta-4.54.2 branch 2 times, most recently from b27f52c to 39e1460 Compare December 10, 2023 11:42
@bwp91 bwp91 force-pushed the beta-4.54.2 branch 2 times, most recently from c70fd34 to 180110d Compare December 11, 2023 14:16
@bwp91 bwp91 changed the title [do not merge] latest <- beta latest <- beta Dec 12, 2023
@bwp91 bwp91 marked this pull request as draft December 12, 2023 12:52
@bwp91 bwp91 force-pushed the beta-4.54.2 branch 2 times, most recently from a5f964e to 57b205f Compare December 13, 2023 07:43
@donavanbecker donavanbecker force-pushed the beta-4.54.2 branch 3 times, most recently from 6561aeb to a3a2331 Compare December 14, 2023 23:02
@bwp91 bwp91 force-pushed the beta-4.54.2 branch 3 times, most recently from 4000195 to be46430 Compare December 28, 2023 13:14
@bwp91 bwp91 marked this pull request as ready for review December 31, 2023 01:35
donavanbecker
donavanbecker previously approved these changes Jan 3, 2024
View reviewed changes
@donavanbecker donavanbecker changed the title latest <- beta 4.55.0 Jan 3, 2024
NorthernMan54
NorthernMan54 reviewed Jan 3, 2024
View reviewed changes
.vscode/settings.json
@@ -3,7 +3,7 @@
"editor.insertSpaces": true,
"files.eol": "\n",
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
"source.fixAll.eslint": "explicit"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't this trigger the await issue earlier this year ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @bwp91 resolved that.

.github/workflows/release.yml Outdated Show resolved Hide resolved
@donavanbecker
Improve GitHub Actions
8577360 
Improve the Release GitHub Actions
@bwp91 bwp91 closed this Jan 5, 2024
@bwp91 bwp91 deleted the beta-4.54.2 branch January 5, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donavanbecker donavanbecker donavanbecker left review comments

@NorthernMan54 NorthernMan54 NorthernMan54 left review comments

Assignees
No one assigned
Labels
latest Related to Latest Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@bwp91 @coveralls @donavanbecker @NorthernMan54 @mkz212 @jsiegenthaler @SonnyT72 @sapireli @Staubgeborener