Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ignorePaths option #1059

Merged
merged 6 commits into from
Apr 27, 2023
Merged

feat: add ignorePaths option #1059

merged 6 commits into from
Apr 27, 2023

Conversation

subzero10
Copy link
Member

@subzero10 subzero10 commented Apr 25, 2023 •
edited

Fixes: #1053

Status

READY

Description

Add an option ignorePaths to allow ignoring certain paths from being uploaded as source maps.

TODO

  • Add ignorePaths option
  • Ignore source maps that have sourcesContent === []
  • Tests for ignorePaths
  • Tests for sourcesContent
  • Documentation

@subzero10 subzero10 added the rollup/vite @honeybadger-io/rollup-plugin label Apr 25, 2023
@subzero10 subzero10 self-assigned this Apr 25, 2023
BethanyBerkowitz
BethanyBerkowitz previously approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@BethanyBerkowitz BethanyBerkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! I added minor comments, I don't think I need re-review unless you prefer me to.

packages/rollup-plugin/src/rollupUtils.ts Outdated Show resolved Hide resolved
packages/rollup-plugin/test/rollupUtils.test.ts Show resolved Hide resolved
@subzero10 subzero10 merged commit 27c357e into master Apr 27, 2023
7 checks passed
@subzero10 subzero10 deleted the ignore_paths_#1053 branch April 27, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethanyBerkowitz BethanyBerkowitz BethanyBerkowitz left review comments

Assignees

@subzero10 subzero10

Labels
rollup/vite @honeybadger-io/rollup-plugin
Projects
None yet
Milestone
No milestone
2 participants
@subzero10 @BethanyBerkowitz