Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Match semantic convention version to SDK semantic conventions #60

Merged
merged 10 commits into from Aug 15, 2023

Conversation

JamieDanielson
Copy link
Contributor

@JamieDanielson JamieDanielson commented Aug 14, 2023

Which problem is this PR solving?

Short description of the changes

  • Drop our version of semantic conventions to 1.17 to match those used in the imported otel-go package
  • Update the README to clarify versions in use (note old semconv listed because that's in current available release)
  • Update releasing notes to remember to adjust README if versions change, and some other cleanup for consistency to other repos
  • Add simple unit test for checking semantic convention version against otel-go imported package semantic convention
  • Add unit tests for resource detector from core (WithHost) and contrib (lambda) to confirm no schema error

How to verify that this has the expected result

Using a detector on the same version should work. These tests should fail if you change the semantic convention version back to 1.18.0 in the imports.

@JamieDanielson JamieDanielson requested a review from a team as a code owner August 14, 2023 19:17
@JamieDanielson JamieDanielson marked this pull request as draft August 14, 2023 19:17
@JamieDanielson JamieDanielson self-assigned this Aug 14, 2023
@JamieDanielson JamieDanielson marked this pull request as ready for review August 14, 2023 21:55
@JamieDanielson JamieDanielson added type: bug Something isn't working version: bump minor A PR that adds behavior, but is backwards-compatible. type: maintenance The necessary chores to keep the dust off. labels Aug 14, 2023
README.md Show resolved Hide resolved
Copy link
Contributor

@vreynolds vreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@vreynolds vreynolds merged commit d1e3a56 into main Aug 15, 2023
7 checks passed
@vreynolds vreynolds deleted the jamie.clarify-otel branch August 15, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: maintenance The necessary chores to keep the dust off. version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants