Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msgpack v4 -> v5 #362

Closed
wants to merge 1 commit into from
Closed

msgpack v4 -> v5 #362

wants to merge 1 commit into from

Conversation

lizthegrey
Copy link
Member

Which problem is this PR solving?

  • profiles show we're spending most of our time in prod refinery in the msgpack code. v4 is no longer under development, and libhoney has already gone to v5 of msgpack. update refinery too in case there's performance improvements to pick up.

Short description of the changes

  • upgrade msgpack dependency major version.

@lizthegrey lizthegrey requested a review from a team December 4, 2021 23:19
@lizthegrey
Copy link
Member Author

Do not merge. vmihailenco/msgpack#327

@lizthegrey lizthegrey marked this pull request as draft December 5, 2021 01:40
@MikeGoldsmith MikeGoldsmith added type: maintenance The necessary chores to keep the dust off. version: bump minor A PR that adds behavior, but is backwards-compatible. labels Dec 6, 2021
@bdarfler bdarfler added the status: revision needed Waiting for response to changes requested. label Jan 29, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Marking this PR as stale because it has been open 30 days with no activity. Please add a comment if this PR is still relevant; otherwise this PR will be automatically closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 1, 2022
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Closing this PR due to inactivity. Please see our Honeycomb OSS Lifecyle and Practices.

@github-actions github-actions bot closed this Mar 9, 2022
@vreynolds vreynolds mentioned this pull request Mar 9, 2022
Open
@MikeGoldsmith MikeGoldsmith deleted the lizf.msgpack branch May 12, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lizthegrey lizthegrey

Labels
Stale status: blocked status: revision needed Waiting for response to changes requested. type: maintenance The necessary chores to keep the dust off. version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lizthegrey @bdarfler @MikeGoldsmith