[WIP] services : sip: implementing sip protocol #406
Conversation
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
=========================================
Coverage ? 41.67%
=========================================
Files ? 78
Lines ? 8796
Branches ? 0
=========================================
Hits ? 3666
Misses ? 4705
Partials ? 425
Continue to review full report at Codecov.
|
services/sip/sip.go
Outdated
|
|
||
| s.Method = args[0] | ||
| s.Uri = args[1] | ||
| s.SIPVersion = strings.TrimSpace(args[2]) |
There was a problem hiding this comment.
Could you add those values also in the event? eg sip.version, sip.method and sip.uri
services/sip/sip.go
Outdated
| return ErrBadMessage | ||
| } | ||
|
|
||
| fn := sipRequest[s.Method] |
There was a problem hiding this comment.
if !ok {
// not supported
return ErrBadMessage
}```
services/sip/sip.go
Outdated
|
|
||
| ch pushers.Channel | ||
|
|
||
| Method, Uri, SIPVersion, Username, Domain string |
There was a problem hiding this comment.
You cannot put values here, those are shared across all connections.
services/sip/request.go
Outdated
| } | ||
|
|
||
| func (s *sipService) checkRequest(line string) bool { | ||
| ok := s.parseURI() |
There was a problem hiding this comment.
Can't we just use url.Parse here?
|
|
||
| args := strings.Split(line, " ") | ||
| if len(args) != 3 { | ||
| return ErrBadMessage |
There was a problem hiding this comment.
We should send a sip response back here.
| import "fmt" | ||
|
|
||
| func (s *sipService) OptionMethod() string { | ||
| return fmt.Sprintf(` |
There was a problem hiding this comment.
Isn't it easier to return a http.Response? then you can also use resp.WriteTo(c)
tobusucs
changed the title
|
take a look at this library, maybe useful: https://github.com/marv2097/siprocket or something comparable |
No description provided.