Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: functiom from filepath and docs #2635

Closed
wants to merge 1 commit into from
Closed

Conversation

mgrithm
Copy link
Contributor

@mgrithm mgrithm commented May 7, 2024

  • Add tests
  • Run tests
  • bun denoify to generate files for Deno

@yusukebe
Copy link
Member

yusukebe commented May 7, 2024

@mgrithm

I appreciate the PR, but I don't really welcome the refactoring because there will be a lot of diffs by those who didn't implement it.

@mgrithm
Copy link
Contributor Author

mgrithm commented May 7, 2024

@yusukebe

I kept the same functionality. I just changed the way we did it for reading/efficiency

@yusukebe
Copy link
Member

yusukebe commented May 8, 2024

I kept the same functionality. I just changed the way we did it for reading/efficiency

I know that. But if this PR is accepted, other parts of it will be refactored. Some styles can implement one logic. However, we currently don't have documentation like the "code-style-guide," so it's not good to refactor the code to your style without it. So, even if it seems like a good idea, it is difficult to accept this. This is the opinion of a maintainer.

@mgrithm
Copy link
Contributor Author

mgrithm commented May 8, 2024

I know that. But if this PR is accepted, other parts of it will be refactored. Some styles can implement one logic. However, we currently don't have documentation like the "code-style-guide," so it's not good to refactor the code to your style without it. So, even if it seems like a good idea, it is difficult to accept this. This is the opinion of a maintainer.

Alright. How can I contribute from other way?

@mgrithm mgrithm closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants