tape@4.5.1 breaks build 🚨 #87
Conversation
|
oha this is legit! tests pass with |
see tape-testing/tape#267 * * * This commit was sponsored by Neighbourhoodie You can hire Neighbourhoodie for all your Hoodie / CouchDB / Offline First needs http://go.hood.ie/thehoodiefirm
|
okay, got it, we used |
| @@ -592,7 +592,7 @@ test('scoped Store .off()', function (t) { | |||
| }) | |||
| }) | |||
|
|
|||
| test('when type change', function (t) { | |||
| test.only('when type change', function (t) { | |||
There was a problem hiding this comment.
Fixed via 46ab321, thanks. And there I thought I wouldn’t need the LGTM workflow as it was "only" a little fix :) Thanks so much for looking into it nevertheless
There was a problem hiding this comment.
Haha 👍 saw your tweet so I took a look! Also, You could probably make a linting rule that checks for test.only
There was a problem hiding this comment.
yeah I thought about that, but we don’t have linting rules at all, we just use standard ¯_(ツ)_/¯
There was a problem hiding this comment.
standard is nice but it just covers the basics of linting style and not anything specific to your own project/framework/etc (if you want to take it farther).
There was a problem hiding this comment.
that’s kinda the point, we try to keep it simple for new contributors, and one thing we try to do is to avoid any kind of extra config or dotfiles. So far we went very well with it :) All these rules tend to overtake and the existing maintainers keep adding them to make their lives easier, but it makes it harder for new contributors
There was a problem hiding this comment.
Makes sense, depending on how badly I wanted more rules I would create my own preset/config (which could include standard) and use that in all repos (so it would be similar to standard, except your own stuff too)
thanks @hzoo #87 (comment) * * * This commit was sponsored by Neighbourhoodie You can hire Neighbourhoodie for all your Hoodie / CouchDB / Offline First needs http://go.hood.ie/thehoodiefirm
Hello 👋
🚨🚨🚨
tape just published its new version 4.5.1, which is covered by your current version range. After updating it in your project the build went from success to failure.
This means your software is now malfunctioning, because of this update. Use this branch to work on adaptions and fixes.
Happy fixing and merging 🌴
The new version differs by 25 commits .
ed40dc8v4.5.1a51a89bMerge pull request #268 from ljharb/throws_non_function_should_fail472b517Ensure that non-functions passed tothrowsfail the test, just likeassert``3227068v4.5.01414948[New] Skipped test blocks should output a “SKIP” message.40be685[Tests] building C extensions on iojs 3 and greater doesn’t work on a stock sudoless travis-ci VM.9a6b655[Dev Deps] updateconcat-stream,falafel,js-yaml,tap-parser``13654ad[Deps] updatedeep-equal,function-bind,glob,object-inspect,resolve,string.prototype.trim,through``545db26doc: Explain opts in t.testba44de6[Tests] remove unnecessary + failing Error message assertion95848f4Travis: Get rid of sudo0538944Merge pull request #238 from ntwb/patch-10f51449Add back iojs40b50d2Test on Node.js v0.10.x, v0.12.x, v4.x, and v5.x6e2e204Merge pull request #233 from joshgillies/masterThere are 25 commits in total. See the full diff.