Switching workspace doesn't invalidate context #4030
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While switching from one workspace to another, it's already being invalidated. However, when switching from the |
|
When switching from a team workspace to another team workspace, in the local storage (selectedEnvIndex), we still have the reference to the previously selected environment, it's not invalidated. I have made a modification to invalidate the environment only if it not a personal environment. |
nivedin
previously approved these changes
May 15, 2024
jobartim44
requested review from
AndrewBastin,
anwarulislam,
ankitsridhar16,
balub,
JoelJacobStephen and
liyasthomas
as code owners
|
The rebase is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we change workspace we should not conserve the environment that is related to the old workspace.
Closes #3864
Description
When switching workspace, we go batck to "NO_ENV_SELECTED" in the local storage