HSB-431 fix: email case sensitive in email provider #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mirarifhasan can you check all places where we use email to do something like admin user invitation etc to see if this issue may exist. |
mirarifhasan
force-pushed
the
fix/email-case-sensitive
branch
from
497201d
to
391e5a2
Compare
balub
approved these changes
May 14, 2024
.../hoppscotch-backend/prisma/migrations/20240507000001_update_email_to_lowercase/migration.sql
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HSB-431
Closes #4027
Description
This pull request addresses a problem where user emails are treated as case-sensitive during signup. This means that signing up with
user@gmail.comandUSER@gmail.comwould create two separate user entries in the database.Solution
This PR implements logic to convert all email addresses to lowercase before saving them in the database. This ensures that regardless of the case used during signup, only one user entry will be created for the same email address.
Checks
Additional Information
Nil