-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to nodejs v18 #465
Conversation
one blocker nock/nock#2397 - @esterlus how would you like to proceed? |
Remove |
🦋 Changeset detectedLatest commit: d19e864 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Should be a minor release, as it is not compatible with the patch before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work,
one minor issue,
yarn format:fix
fails because of devkit sandbox. I guess that was the same before.
And one minor request,
please apply this patch before landing:
diff --git a/.envrc b/.envrc
index 8700a1b..3550a30 100644
--- a/.envrc
+++ b/.envrc
@@ -1,2 +1 @@
-export NIXPKGS_ALLOW_INSECURE=1
use flake
Upgrades RPCh to work with nodejs 18
cross-fetch
andnode-fetch
since nodejs 18 introduces global afetch
nock
testing librarytypes/fetch
package to provide fetch types across the monorepo