Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to nodejs v18 #465

Merged
merged 10 commits into from
Jul 25, 2023
Merged

upgrade to nodejs v18 #465

merged 10 commits into from
Jul 25, 2023

Conversation

nionis
Copy link
Contributor

@nionis nionis commented Jul 19, 2023

Upgrades RPCh to work with nodejs 18

  • upgrades all docker images to nodejs 18
  • removes all uses of cross-fetch and node-fetch since nodejs 18 introduces global a fetch
  • removes outdated & disabled funding functionality in DP
  • removes nock testing library
  • rewrite some tests
  • update global typescript config to better match what nodejs18 offers
  • introduce internal types/fetch package to provide fetch types across the monorepo

@nionis nionis added the enhancement New feature or request label Jul 19, 2023
@nionis nionis self-assigned this Jul 19, 2023
packages/common/package.json Outdated Show resolved Hide resolved
packages/sdk/package.json Outdated Show resolved Hide resolved
@nionis
Copy link
Contributor Author

nionis commented Jul 24, 2023

one blocker nock/nock#2397 - @esterlus how would you like to proceed?

@esterlus
Copy link
Member

Remove nock and replace test occurances with real node servers or remove needlessly mocked tests.

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023

🦋 Changeset detected

Latest commit: d19e864

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@rpch/ethereum-provider Minor
@rpch/availability-monitor Minor
@rpch/discovery-platform Minor
@rpch/funding-service Minor
@types/fetch Minor
@rpch/configs-typescript Minor
@rpch/rpc-server Minor
@rpch/common Minor
@rpch/ethers Minor
@rpch/exit-node Minor
@rpch/manager Minor
@rpch/sandbox Minor
@rpch/sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nionis nionis requested a review from esterlus July 25, 2023 07:28
@nionis nionis marked this pull request as ready for review July 25, 2023 07:51
@esterlus
Copy link
Member

Should be a minor release, as it is not compatible with the patch before

Copy link
Member

@esterlus esterlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work,
one minor issue,
yarn format:fix fails because of devkit sandbox. I guess that was the same before.

And one minor request,
please apply this patch before landing:

diff --git a/.envrc b/.envrc
index 8700a1b..3550a30 100644
--- a/.envrc
+++ b/.envrc
@@ -1,2 +1 @@
-export NIXPKGS_ALLOW_INSECURE=1
 use flake

@esterlus esterlus merged commit 191b247 into main Jul 25, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants