Fix public key prefix protocol bug #5665
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the 0xff public key prefix problem
Teebor-Choka
approved these changes
Oct 24, 2023
tolbrino
requested changes
Oct 25, 2023
|
This goes in 3.0 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protocol design was relying on the first byte of public key to never be equal to
0xff. This was true for secp256k1 keys.However, it is not the case for Ed25519 public keys as the top-most bit is set depending on the point sign.
This PR fixes this problem by re-organizing the header format, so that the path position is the first byte (possible values:
0x00,0x01,0x02) and the0xffis set for the last hop.This change is backwards incompatible, so it should be merged along with the next backwards incompatible release.