Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: provide correct types path in conditional exports #222

Merged
merged 1 commit into from Dec 30, 2023
Merged

fix: provide correct types path in conditional exports #222

merged 1 commit into from Dec 30, 2023

Conversation

auvred
Copy link
Contributor

@auvred auvred commented Dec 28, 2023

I missed it somehow in #195

When working in TypeScript project with moduleResolution set to node16, nodenext, or bundler, it's impossible to import type Options from the package, because its types are resolved to ./dist/types

prettier-plugin-jsdoc/src/index.ts

Line 240 in a774106

export type Options = Partial<JsdocOptions>;

auvred added a commit to auvred/eslint-config that referenced this pull request Dec 28, 2023
@auvred
chore: hosseinmd/prettier-plugin-jsdoc#222
375ad17
@hosseinmd hosseinmd merged commit 7a884b6 into hosseinmd:master Dec 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@auvred @hosseinmd