Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pytest and minor dependencies #51

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Upgrade pytest and minor dependencies #51

merged 1 commit into from
Nov 22, 2022

Conversation

conatus
Copy link
Collaborator

@conatus conatus commented Nov 22, 2022

pytest the Python testing library depends upon a library called py. This library has a very minor and near impossible to exploit vulnerability in it. However, this vulnerablity has been given a CVE which means it is marked as serious and blocks our deploy pipeline.

The authors of pytest have removed py and "vendored" it, meaning they've taken the functionality they need into their main package and removed the need for this dependency. Thus avoiding the (false) CVE now and in future.

See for more dertails:

This upgrades pytest to the latest version. The tests, such as they are, run, which means that this is a safe update.

Currently the pipelines on #50, #49, #41 at minimum are not completing due to this issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I've checked the spec (e.g. Figma file) and documented any divergences.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I've updated the documentation accordingly.
  • Replace unused checkboxes with bullet points.

@conatus conatus self-assigned this Nov 22, 2022
@conatus conatus merged commit 44c9563 into main Nov 22, 2022
@conatus conatus deleted the update-pytest branch November 22, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant