Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace make_response with jsonify #4160

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

codelion
Copy link

@codelion codelion commented Nov 7, 2023

Since the intention here is to output JSON it will be better to use jsonify instead of make_reponse.

@xlqian
Copy link
Member

xlqian commented Nov 27, 2023

Hi, thank you for the contribution. SInce the credentials are accessible solely from hove-io/navitia, tests/checks can't run successfully over forked repo, can I open a new PR by cherry-picking your commits?

cheers

@codelion
Copy link
Author

Yes, please go ahead @xlqian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants