New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jormun]: add parameter requested_datetime in direct_path journey #4271

Merged

azime merged 3 commits into dev from fix_add_requested_date_time_in_direct_path

May 21, 2024

Contributor

kadhikari commented May 15, 2024

Attribute journey.requested_date_time is absent in direct_path journey provided by some connectors like Andyamo and Geovelo.
Even if this information is deprecated since some years (

navitia/source/jormungandr/jormungandr/interfaces/v1/serializer/journey.py

Line 435 in c7ab270

requested_date_time = DateTimeField(deprecated=True)

), attribute is added for these two connectors.
Attribute is present for connectors like Asgard, RideSharing, and others..

Concerned ticket: https://navitia.atlassian.net/browse/NAV-2874


          [jormun]: add parameter requested_datetime in direct_path journey

f6626e6

kadhikari requested review from adrien3d, azime, xlqian, SGrenet and pbench

May 15, 2024 12:10

xlqian approved these changes

View reviewed changes

kadhikari added 2 commits

May 15, 2024 14:26


          Formatting

9dffa1b


          Attribute added for handimap

9ea1afb

xlqian approved these changes

View reviewed changes

sonarcloud bot commented May 16, 2024

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

azime approved these changes

View reviewed changes

azime merged commit bede9ec into dev

9 checks passed

azime deleted the fix_add_requested_date_time_in_direct_path branch

May 21, 2024 08:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment