added removeAllListeners #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR and our apologies it has been quiet on this PR for so long. Please read #158 for a general update on what's happening in this repo. This PR seems like a good addition to the current function stack. Could you edit the readme in this PR as well? |
jdegger
requested changes
Oct 31, 2020
Comment on lines
+117
to
+119
| _eventHandlers[type].forEach(value => { | ||
| value.remove() | ||
| }) |
There was a problem hiding this comment.
the foreach introduces a race condition here where removeAllListeners might return before all event handlers are removed.
Converting it to a traditional for-loop or returning a resolved promise when done will resolve this issue.
|
@benminer this PR is alsmost finished but requires a docs update, are you willing to create a new PR with this PR included + the readme change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.