firebase pn support #208
Open
firebase pn support #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed app crash when receiving voip push notification in background ios
jdegger
requested changes
Aug 8, 2022
| @@ -284,7 +305,7 @@ private void setCallInProgressNotification(CallInvite callInvite, int notificati | |||
| int importance = NotificationManager.IMPORTANCE_LOW; | |||
| if (!isAppVisible()) { | |||
| if (BuildConfig.DEBUG) { | |||
| Log.i(TAG, "app is NOT visible."); | |||
| Log.i(TAG, "app is NOT visible eeeee."); | |||
There was a problem hiding this comment.
Suggested change
| Log.i(TAG, "app is NOT visible eeeee."); | |
| Log.i(TAG, "app is NOT visible."); |
| @@ -240,7 +259,9 @@ private String createChannel(int channelImportance) { | |||
| } | |||
|
|
|||
| private void accept(CallInvite callInvite, int notificationId) { | |||
| Log.d(TAG, "accept()1"); | |||
There was a problem hiding this comment.
Suggested change
| Log.d(TAG, "accept()1"); |
| @@ -73,9 +86,9 @@ public void onCallInvite(final CallInvite callInvite) { | |||
| Handler handler = new Handler(Looper.getMainLooper()); | |||
| handler.post(new Runnable() { | |||
| public void run() { | |||
| CallNotificationManager callNotificationManager = new CallNotificationManager(); | |||
| // CallNotificationManager callNotificationManager = new CallNotificationManager(); | |||
There was a problem hiding this comment.
if not needed anymore, remove line
remove lines `not needed`
change getService to getActivity for issues Notification trampoline…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resolution to the issue where a call could not be completed with the existence of Firebase in the project.