Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create npm audit workflow #1629

Merged
merged 6 commits into from Mar 4, 2020
Merged

create npm audit workflow #1629

merged 6 commits into from Mar 4, 2020

Conversation

adrianjost
Copy link
Contributor

@adrianjost adrianjost self-assigned this Mar 4, 2020
@pullapprove pullapprove bot requested a review from CordlessWool March 4, 2020 08:28
@pullapprove
Copy link

pullapprove bot commented Mar 4, 2020

Hey @adrianjost, thanks for the PR! The review will start once
the tests, CI checks and PR requirements (see checklist in your PR) have passed.

@adrianjost adrianjost requested review from Parnswir and removed request for CordlessWool March 4, 2020 08:29
@Parnswir
Copy link
Contributor

Parnswir commented Mar 4, 2020

Nice, but it fails due to dev-dependencies right now although it shouldn't with --only=prod 😄

@adrianjost
Copy link
Contributor Author

@Parnswir It's a known bug 😅🙄

https://npm.community/t/npm-audit-without-fix-ignores-only-prod/3959/7

with an open PR

npm/cli#125

@adrianjost
Copy link
Contributor Author

I have now seperated DEV & PROD checks so we can monitor them seperatly as long as they are not both green

Parnswir
Parnswir approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@Parnswir Parnswir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks great 👍

@Parnswir Parnswir added ready to merge This Pull is waiting to be merged. May the bot does this for you and removed waiting for review labels Mar 4, 2020
@mergify mergify bot merged commit 7ba96ee into develop Mar 4, 2020
@mergify mergify bot deleted the feature/OPS-247 branch March 4, 2020 11:05
@mergify mergify bot added auto_merged and removed ready to merge This Pull is waiting to be merged. May the bot does this for you labels Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parnswir Parnswir Parnswir approved these changes

Assignees

@adrianjost adrianjost

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@adrianjost @Parnswir