fix node loading depth

hpi-schul-cloud · May 17, 2024 · b738f74 · b738f74
1 parent 58be6e8
commit b738f74
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/apps/server/src/modules/board/service/board-node-authorizable.service.ts b/apps/server/src/modules/board/service/board-node-authorizable.service.ts
@@ -26,8 +26,8 @@ export class BoardNodeAuthorizableService implements AuthorizationLoaderService
 	}
 
 	async getBoardAuthorizable(boardNode: AnyBoardNode): Promise<BoardNodeAuthorizable> {
-		const rootNode = await this.boardNodeService.findRoot(boardNode, 1);
-		const parentNode = await this.boardNodeService.findParent(boardNode, 1);
+		const rootNode = await this.boardNodeService.findRoot(boardNode);
+		const parentNode = await this.boardNodeService.findParent(boardNode);
 		const users = await this.boardContextService.getUsersWithBoardRoles(rootNode);
 
 		const boardNodeAuthorizable = new BoardNodeAuthorizable({

diff --git a/apps/server/src/modules/board/service/board-node.service.ts b/apps/server/src/modules/board/service/board-node.service.ts
@@ -20,7 +20,7 @@ export class BoardNodeService {
 		await this.boardNodeRepo.persistAndFlush(boardNode);
 	}
 
-	async addToParent(parent: AnyBoardNode, child: AnyBoardNode, position = 0): Promise<void> {
+	async addToParent(parent: AnyBoardNode, child: AnyBoardNode, position?: number): Promise<void> {
 		parent.addChild(child, position);
 		await this.boardNodeRepo.persistAndFlush(parent);
 	}
@@ -47,8 +47,8 @@ export class BoardNodeService {
 
 	async move(childId: EntityId, targetParentId: EntityId, targetPosition?: number): Promise<void> {
 		const child = await this.findById(childId);
-		const parent = await this.findParent(child, 1);
-		const targetParent = await this.findById(targetParentId, 1);
+		const parent = await this.findParent(child);
+		const targetParent = await this.findById(targetParentId);
 
 		// TODO should we make sure child and targetParent belonging to the same board?