-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPS-5142-add-bucket-names-h5p #4618
Open
aimee-889
wants to merge
287
commits into
main
Choose a base branch
from
OPS-5142-add-bucket-names-h5p
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add list of files * change s3 command type * fix tests * move recursive part to private methode * fix limits --------- Co-authored-by: Marvin Rode (Cap) <127723478+marode-cap@users.noreply.github.com>
…i-schul-cloud/schulcloud-server into THR-18-dev-feature-h5p-editor
* Preparing entities for authorization * Add entities * save and create tests * get player tests * get editor tests * files uc tests * last tests for changed UC * better error message
This reverts commit 1c1e734.
…gement-service # Conflicts: # apps/server/src/modules/h5p-editor/service/libraryStorage.service.spec.ts # apps/server/src/modules/h5p-editor/service/libraryStorage.service.ts # apps/server/src/modules/h5p-editor/uc/h5p-files.uc.spec.ts # apps/server/src/modules/h5p-editor/uc/h5p.uc.ts
…ment-service # Conflicts: # apps/server/src/modules/files-storage/interface/storage-client.ts # apps/server/src/shared/infra/s3-client/s3-client.adapter.ts # apps/server/src/shared/testing/factory/index.ts
…ment-service # Conflicts: # apps/server/src/shared/testing/factory/index.ts
…nto THR-35-library-management-service # Conflicts: # apps/server/src/modules/files-storage/interface/storage-client.ts # apps/server/src/shared/infra/s3-client/s3-client.adapter.ts # apps/server/src/shared/testing/factory/index.ts
…e-transfer-showcase
…ucket-names-h5p
aimee-889
added
the
WIP
This feature branch is in progress, do not merge into master.
label
Dec 6, 2023
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use separate keys for access to content bucket and library bucket
the new vars to the schema list
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.