Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPS-5142-add-bucket-names-h5p #4618

Open
wants to merge 287 commits into
base: main
Choose a base branch
from
Open

Conversation

aimee-889
Copy link
Contributor

Description

  • use separate keys for access to content bucket and library bucket

  • the new vars to the schema list

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

SteKrause and others added 30 commits August 25, 2023 10:26
* add list of files

* change s3 command type

* fix tests

* move recursive part to private methode

* fix limits

---------

Co-authored-by: Marvin Rode (Cap) <127723478+marode-cap@users.noreply.github.com>
* Preparing entities for authorization

* Add entities

* save and create tests

* get player tests

* get editor tests

* files uc tests

* last tests for changed UC

* better error message
…gement-service

# Conflicts:
#	apps/server/src/modules/h5p-editor/service/libraryStorage.service.spec.ts
#	apps/server/src/modules/h5p-editor/service/libraryStorage.service.ts
#	apps/server/src/modules/h5p-editor/uc/h5p-files.uc.spec.ts
#	apps/server/src/modules/h5p-editor/uc/h5p.uc.ts
…ment-service

# Conflicts:
#	apps/server/src/modules/files-storage/interface/storage-client.ts
#	apps/server/src/shared/infra/s3-client/s3-client.adapter.ts
#	apps/server/src/shared/testing/factory/index.ts
…ment-service

# Conflicts:
#	apps/server/src/shared/testing/factory/index.ts
…nto THR-35-library-management-service

# Conflicts:
#	apps/server/src/modules/files-storage/interface/storage-client.ts
#	apps/server/src/shared/infra/s3-client/s3-client.adapter.ts
#	apps/server/src/shared/testing/factory/index.ts
@aimee-889 aimee-889 added the WIP This feature branch is in progress, do not merge into master. label Dec 6, 2023
Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP This feature branch is in progress, do not merge into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants