Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMED-119 - Spike: direktes Einbinden der edu-sharing-Suchumgebung in den "Lern-Store" der SVS #4692

Draft
wants to merge 114 commits into
base: main
Choose a base branch
from

Conversation

bergatco
Copy link
Contributor

Description

The aim of this spike is to evaluate how the edu-sharing search environment can best be integrated as a "learning store" within the school cloud network software.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/DMED-119
hpi-schul-cloud/dof_app_deploy#713
hpi-schul-cloud/nuxt-client#2933

Links to deployments :
https://dmed-119-integration-of-search-environment.dbc.dbildungscloud.dev/
https://dmed-119-integration-of-search-environment.nbc.dbildungscloud.dev/
https://dmed-119-integration-of-search-environment.brb.dbildungscloud.dev/

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bergatco bergatco closed this Jan 16, 2024
@bergatco bergatco deleted the DMED-119-integration-of-search-environment branch January 16, 2024 07:30
@bergatco bergatco restored the DMED-119-integration-of-search-environment branch March 20, 2024 12:45
@bergatco
Copy link
Contributor Author

Reopened due to new requirements (additional API endpoint for logging in to edu-sharing repository and receiving a valid ticket for the web component).

@bergatco bergatco reopened this Mar 20, 2024
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
72 Uncovered Lines on New Code (required ≤ 0)

See analysis details on SonarCloud

*/
private sign(data: string): string {
const sign = createSign('SHA1');
sign.write(data);

Check failure

Code scanning / CodeQL

Use of a broken or weak cryptographic algorithm High

A broken or weak cryptographic algorithm
depends on
sensitive data from an access to userName
.
A broken or weak cryptographic algorithm
depends on
sensitive data from an access to userName
.
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2.5% Coverage on New Code (required ≥ 80%)
78 Uncovered Lines on New Code (required ≤ 0)

See analysis details on SonarCloud

bergatco and others added 19 commits May 28, 2024 09:43
- Update replicas for API EduSharing deployment
- Update container port for API EduSharing
- Update ports for readiness and liveness probes
- Update resource limits and requests for API EduSharing
- Remove "SERVICE_BASE_URL" property from default schema
- Set default value for "APP_ID" property in default schema to "schul-cloud"
- Remove "EDU_SHARING__API_URL" property from development config
…ringService` to use `LoginDto` as return type for `getTicketAuthenticationInfo`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge WIP This feature branch is in progress, do not merge into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet