-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N21-1511 Oauth provider refactoring #4694
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # apps/server/src/modules/tool/external-tool/external-tool.module.ts
Why do you wan't to delete the infra redis part? |
apps/server/src/modules/oauth-provider/api/oauth-provider.client-crud.uc.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/oauth-provider/api/oauth-provider.logout-flow.uc.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/oauth-provider/api/oauth-provider.uc.ts
Outdated
Show resolved
Hide resolved
It is not used anymore and we had review comments about improper logging, so the conclusion is to delete the dead code that does not adhere to our code standards. |
# Conflicts: # apps/server/src/modules/group/controller/api-test/group.api.spec.ts
apps/server/src/modules/oauth-provider/domain/error/hydra-oauth-failed-loggable-exception.ts
Outdated
Show resolved
Hide resolved
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Question solved by #4702 was this redis removed |
import { Test, TestingModule } from '@nestjs/testing'; | ||
import { Pseudonym, UserDO } from '@shared/domain/domainobject'; | ||
import { TeamEntity } from '@shared/domain/entity'; | ||
import { TeamsRepo } from '@shared/repo'; | ||
import { externalToolFactory, pseudonymFactory, setupEntities, userDoFactory } from '@shared/testing'; | ||
import { teamFactory } from '@shared/testing/factory/team.factory'; | ||
import { PseudonymService } from '../../../pseudonym/service'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imports
Description
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/N21-1511
hpi-schul-cloud/nuxt-client#3006
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.