Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-6871 - Adapt board domain object mapping to unified persistence entity #4964

Open
wants to merge 103 commits into
base: main
Choose a base branch
from

Conversation

uidp
Copy link
Contributor

@uidp uidp commented Apr 25, 2024

Description

To make it easier to extend the board we want to adapt the mapping of board domain objects to the prior implemented board node persistence entity.

Currently when persisting a board DO we have to create an instance of specific persistence entity class. This is implemented using the visitor pattern and requires specific mapping code for each persistence entity class.

Instead we can do better by:

  • using one unified persistence entity (see BC-6870)
  • get or create the persistence object in the Unit of Work in the ORM
  • update the properties of the persistence object

This should not be specific to the board DO. We should treat the persistence entity just as a data container.

Links to Tickets or other pull requests

BC-6871

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@uidp uidp added the WIP This feature branch is in progress, do not merge into master. label Apr 25, 2024
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
76.5% Coverage on New Code (required ≥ 80%)
56 Uncovered Lines on New Code (required ≤ 0)

See analysis details on SonarCloud

@virgilchiriac
Copy link
Contributor

virgilchiriac commented May 27, 2024

this branch and PR is old (used as backup)

see the new one here: #5030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge WIP This feature branch is in progress, do not merge into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants