Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EW-649: Refactoring of authentication. #5010

Merged
merged 8 commits into from
May 24, 2024
Merged

EW-649: Refactoring of authentication. #5010

merged 8 commits into from
May 24, 2024

Conversation

mkreuzkam-cap
Copy link
Contributor

@mkreuzkam-cap mkreuzkam-cap commented May 17, 2024

Description

  • Move classes which are not strategies to helper folder
  • Check todos
  • Add comments to explain unused variables
  • Add typeguard for user
  • Change type of bruteforce error
  • Restructure some code

Links to Tickets or other pull requests

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@mkreuzkam-cap mkreuzkam-cap enabled auto-merge (squash) May 23, 2024 14:06
Copy link

sonarcloud bot commented May 24, 2024

@mkreuzkam-cap mkreuzkam-cap merged commit 8eb5e1b into main May 24, 2024
53 of 55 checks passed
@mkreuzkam-cap mkreuzkam-cap deleted the EW-649 branch May 24, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants