Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the option to specify mouse position for the DND events #20

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

vzaidman
Copy link

@vzaidman vzaidman commented May 1, 2017

breaking change: defaults drags and drops to the center of the relevant elements.

@zubivan
Copy link

zubivan commented May 5, 2017

@vzaidman Great to see that someone also needs this! Thanks for continuing on what I started! 👍
I was also thinking of creating a PR for this, though fixing integration tests is a bit of a hustle. And I'm not entirely sure whether my approach with createMouseEvent works nicely cross browser (https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/initMouseEvent).

@wushan
Copy link

wushan commented Jun 22, 2017

this feature would be super useful. Hope this will be merge soon !

@pschroeder89
Copy link

@vzaidman Any work still being done on this?

@vzaidman
Copy link
Author

vzaidman commented Dec 5, 2017

it works as far as i know.
I didn't used it in the end.
whoever wants, please fix the tests and merge it.

@pschroeder89
Copy link

pschroeder89 commented Dec 5, 2017

Tests should be fixed in this PR: PowToon#1

Please approve and merge so we can merge this PR, too

@pschroeder89
Copy link

pschroeder89 commented Dec 5, 2017

This is turning out to be more work than it's worth for me. I'll try to revisit in a few days when I have some downtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants