Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy-pass option to avoid changing Host header #199

Closed
wants to merge 2 commits into from

Conversation

developit
Copy link

This adds a proxy-pass boolean option, which prevents the proxy from changing the origin of the host header to the target URL.

See changeOrigin option here: https://github.com/nodejitsu/node-http-proxy#options

developit and others added 2 commits October 23, 2015 21:24
Adding `proxy-pass` prevents the proxy from changing the origin of the host header to the target URL.
@0xR
Copy link

0xR commented Oct 29, 2018

This is actually quite a old PR. I need this functionality as well. Did you find a workaround by now? @developit

@angelkenneth
Copy link

angelkenneth commented Dec 18, 2018

I had to copy and paste the bin/http-server and lib/http-server.js files to my own project just so i can set changeOrigin: false.

Still hoping this will be merged.

@thornjad thornjad self-requested a review April 17, 2019 14:15
@thornjad thornjad added this to the v0.12.0 milestone Apr 17, 2019
@fabioimpe
Copy link

fabioimpe commented May 10, 2019

@indexzero Please I need this functionality too, is there any chance too see this PR merged?

Thank you

@thornjad thornjad modified the milestones: v0.12.0, v0.13.0 Nov 19, 2019
@thornjad
Copy link
Member

This looks reasonably straightforward and useful! However there are some merge conflicts which need to be resolved before this can move forward, @developit could you take a look at those?

@thornjad
Copy link
Member

Given the variety of options available in http-proxy, this may be better implemented with the approach of passing through options to http-proxy itself in #459, what do you think?

@thornjad
Copy link
Member

Closing in favor of #495

@thornjad thornjad closed this Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants