Fixes #246: Add option --auto to set proxy option autoRewrite #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add handling for --auto flag
thornjad
requested changes
Feb 3, 2019
| @@ -32,6 +33,7 @@ if (argv.h || argv.help) { | |||
| ' -U --utc Use UTC time format in log messages.', | |||
| '', | |||
| ' -P --proxy Fallback proxy if the request cannot be resolved. e.g.: http://someurl.com', | |||
| ' --auto Set proxy autoRewrite flag for proxy, handling 301/302 responses', | |||
There was a problem hiding this comment.
Instead of changing auto to autoRewrite later, I think it would be simpler and more clear to use the option --auto-rewrite from the start instead. Otherwise I think this looks good.
|
@kwesterfeld looks like we have some merge conflicts to take a look at |
|
Given the variety of options available in http-proxy, I'm going to close this in favor of the approach of passing through options to http-proxy itself in #459, which would solve this same issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #246