Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates details.family check for Node v18 #816

Closed
wants to merge 1 commit into from

Conversation

dmalan
Copy link

@dmalan dmalan commented May 29, 2022

Relevant issues

Fixes #815.

Whereas os.networkinterfaces used to return a String value for family like 'IPv4' in Node v17 and prior, per https://nodejs.org/docs/latest-v17.x/api/os.html#osnetworkinterfaces, it seems to have changed to a Number like 4 in Node v18, per https://nodejs.org/docs/latest-v18.x/api/os.html#osnetworkinterfaces.

Contributor checklist
  • The pull request is being made against the master branch

(No existing tests to update.)

Maintainer checklist
  • Assign a version triage tag
  • Approve tests if applicable

@zbynek
Copy link
Contributor

zbynek commented May 29, 2022

The issue is duplicate of #810 and there is another proposed fix already in #811

@thornjad
Copy link
Member

Correct, duplicate of #811, and I very marginally like #811's implementation better

@thornjad thornjad closed this May 31, 2022
@dmalan dmalan deleted the patch-1 branch May 31, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Available on: text without right hand side, where are files being served?
3 participants