Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Mime to MediaType #295

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brightly-salty
Copy link
Contributor

@brightly-salty brightly-salty commented Dec 8, 2020

This is a WIP: will only be merged after other semver-major changes, and will likely have conflicts then.

This PR renames the mime module to media_type, the Mime struct to MediaType, any associated functions with "mime" in their name to "media_type", any mime fields to media_type, and all related docs have also changed.

Fixes #251.

This is my first PR for http-types. Let me know if anything else is needed of me.

@Fishrock123 Fishrock123 added the semver-major This change requires a semver major change label Dec 8, 2020
@Fishrock123 Fishrock123 added this to the 3.0 milestone Dec 8, 2020
@yoshuawuyts
Copy link
Member

@brightly-salty thanks so much for this PR. We'll indeed have to wait to merge this until we're ready for a 3.0 (which may be soon-ish actually). But it appears some of the comments have been caught in the diff too: "Mime type" in docs should probably be rename to "media type". Currently some examples appear to be "MediaType type" and "media_type type". If you could do another pass to update the comments, that'd be 💯

Replace "media_type type" with "media type" in comments
Replace "MediaType type" with "media type" in comments
@yoshuawuyts yoshuawuyts marked this pull request as draft December 24, 2020 14:17
@yoshuawuyts
Copy link
Member

Converted to draft so we don't actually merge it. But there already appear to be merge conflicts. These don't need to be resolved straight away, but it's probably worth pointing out regardless.

In terms of timing for an http-types 3.0 release; we're having a meeting early next year with the core team to determine the schedule for that. Having all this work already ready to be merged is a huge boon and gives us confidence we'll be able to make this release happen sooner rather than later. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major This change requires a semver major change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename Mime to MediaType
3 participants