Only create scalafix job for 2.13 #6361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
May 2, 2022
| @@ -39,10 +39,9 @@ ThisBuild / githubWorkflowAddedJobs ++= Seq( | |||
| WorkflowStep.Run( | |||
| List("cd scalafix", "sbt ci"), | |||
There was a problem hiding this comment.
Still, this fast-running job is not particularly helpful for our cache, since it doesn't use the primary build.sbt. This is something to fix in sbt-typelevel.
danicheg
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all the extra jobs were worthless, because they weren't doing anything.
Secondly, because they ran so quickly (i.e. without starting sbt and downloading stuff) they were the first in line to upload the cache ... of nothing 馃檭
Fixes #6360.