fix: drop wee malloc to remove memory leaks #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repeatedly calling this library causes unbounded memory growth. Wee-alloc has known memory leak issues. See rustwasm/wee_alloc#106 Rust's standard library allocator can be used instead.
|
|
|
Amazing work, thanks @RossWilliams! Hunting that down would have taken me absolutely ages, thank you so much 👏 👏 👏 Seems like all the tests still work nicely, and the resulting package size is almost identical (+2KB on each 1.4MB binary) so really no downside at all. I'll merge now & push a new release shortly. By the way, in case you're not aware, HTTP Toolkit Pro is completely free for all contributors to the repos in this org, and this definitely counts! If you're interested, just let me know your email and I'll set you up with an account. More info: https://github.com/httptoolkit/httptoolkit/#contributing-directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeatedly calling this library causes unbounded memory growth. Wee-alloc has known memory leak issues.
See rustwasm/wee_alloc#106
Rust's standard library allocator can be used instead.
resolves #16