Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Theme #115

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

New Theme #115

wants to merge 2 commits into from

Conversation

xKiian
Copy link

@xKiian xKiian commented Apr 30, 2024

I added a new theme named Dark Blue. Sadly, I couldn't figure out how to change the Monaco theme to a more blue one, but other than that, it's a great alternative to the normal dark mode.

Also, it would be cool to have a better theme switcher/manager. (I just had no idea how to implement it in a way where it doesn't look ugly.)

I also fixed a small bug in the 'send' tab where it showed the wrong color.

- new theme: dark blue
- changed the sendpage background to the right color
@CLAassistant
Copy link

CLAassistant commented Apr 30, 2024

CLA assistant check
All committers have signed the CLA.

@xKiian
Copy link
Author

xKiian commented Apr 30, 2024

here are some screenshots of the theme:

grafik
grafik
grafik

@pimterry
Copy link
Member

Nice work @xKiian! This looks great.

That said, this has come at a slightly unlucky time - if you look at the rebrand branch, there's a general UI styling update that's being worked on (with slightly different colours, a proper logo, a few small layout tweaks) and that includes various changes to the existing themes and their properties, that will have a few conflicts with this, and there's more changes coming there in future too.

You might find it interesting though as I did eventually work out how to modify the Monaco background colour 😄

I'm also a bit cautious about adding more and more themes built into the tool... I think it would probably be better to make it easy for people to write & share themes themselves, and provide a UI button to easily load them into the app.

In that approach, you could publish this theme as a JSON file, and others could easily use it and share their own themes and modifications too. I'd be happy to add a page to the official docs explaining this and providing a link to any custom themes that people publish. What do you think?

@xKiian
Copy link
Author

xKiian commented Apr 30, 2024

Yeah, that's a good idea.

@pimterry pimterry force-pushed the main branch 2 times, most recently from e0e350c to 1d713c8 Compare May 7, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants